feat(connect): support promise for connectionString #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghmeier
approved these changes
Dec 16, 2019
added 2 commits
December 16, 2019 10:33
There are cases where it's useful to have a synchronous reference to the Database, and where the connection information is not yet available - particularly in test cases where you may be launching a temporary mongo database using mongo-memory-server. To better support this use-case, the Database class can accept and store the connectionString parameter as a Promise, and resolve it to its value in the connect handler which is already well-positioned to wait for asynchronous resolution.
skeggse
force-pushed
the
support-promise-connection
branch
from
dbc6afc
to
a0f3a59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases where it's useful to have a synchronous reference to the
Database, and where the connection information is not yet available - particularly in test cases where you may be launching a temporary mongo database usingmongo-memory-server. To better support this use-case, theDatabaseclass can accept and store theconnectionStringparameter as aPromise, and resolve it to its value in the connect handler which is already well-positioned to wait for asynchronous resolution.