fix: report writeErrors for bulk ops
#48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shils
reviewed
Apr 16, 2020
shils
reviewed
Apr 16, 2020
Collates the `writeErrors` reported by bulk operations and returns them in the `result` object. We chose to not do the same for `writeConcernErrors`, as our testing indicated that the driver throws on write concern errors rather than returning them.
sbalaji1996
force-pushed
the
srinand/report-writeerrors
branch
from
533b236
to
aee3b18
Compare
sbalaji1996
changed the title
writeErrors and writeConcernErrors for bulk opswriteErrors for bulk ops
shils
approved these changes
Apr 16, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collates the
writeErrorsreported by bulk operations and returns them in theresultobject.We chose to not do the same for
writeConcernErrors, as our testing indicatedthat the driver throws on write concern errors rather than returning them.