Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support get_database() with no name parameter #364

Closed
zachmullen opened this issue Dec 14, 2017 · 1 comment
Closed

Support get_database() with no name parameter #364

zachmullen opened this issue Dec 14, 2017 · 1 comment

Comments

@zachmullen
Copy link
Contributor

As of pymongo 3.5, get_default_database() has been deprecated, and the recommended practice is to use get_database() with no name parameter. Downstreams using this new method are currently unable to use the latest version of mongomock.
@zachmullen
Copy link
Contributor Author

For more info, the method that needs fixed is mongomock.MongoClient.get_database, and the error message is TypeError: get_database() takes at least 2 arguments (1 given).

zachmullen added a commit to zachmullen/mongomock that referenced this issue Dec 14, 2017
@zachmullen
Fixes mongomock#364. Support no-argument get_database() semantics
1fcef59
zachmullen added a commit to zachmullen/mongomock that referenced this issue Jan 15, 2018
@zachmullen
Fixes mongomock#364. Support no-argument get_database() semantics
287f07e
@zachmullen zachmullen mentioned this issue Jan 25, 2018
Merged
vmalloc added a commit that referenced this issue Jan 25, 2018
@vmalloc
Merge pull request #365 from zachmullen/support-get-database-default
5fb1af6 
Fixes #364. Support no-argument get_database() semantics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zachmullen