Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get ready for pymongo v4 #744

Closed
10 tasks done
pcorpet opened this issue Jan 17, 2022 · 0 comments
Closed
10 tasks done

Get ready for pymongo v4 #744

pcorpet opened this issue Jan 17, 2022 · 0 comments
Assignees
@pcorpet
Labels
Work In Progress

Comments

@pcorpet
Copy link
Member

pcorpet commented Jan 17, 2022 •
edited

Many changes have happened between pymongo v3 and v4. Let's track the changes required to be ready for major release of mongomock that supports both pymongo v3 and v4. See migration guide for pymongo.

  • Drop official support for python 2
  • Update the CI to test both for pymongo v3 and pymongo v4 (that would need to skip or update tests using old values)
  • Add tests for the v4 way of doing skipped tests of v3 if possible
  • Add tests that removed functions in v4 are not supported if pymongo v4 is there
  • Make a decision on which version (v3 or v4) is the default if no pymongo version is detected (probably v4)

Changes I've noted are not yet done:

  • MongoClient.database_names
  • Databasee.collection_names
  • Cursor.count
  • Collection.group
  • Collection.reindex
@pcorpet pcorpet self-assigned this Jan 17, 2022
pcorpet added a commit that referenced this issue Jan 17, 2022
@pcorpet
Drop support for Python 2 and Python 3.5.
5a00761 
This commit is only dropping the official support, including stop
testing in the CI. However the code might still work with Python 2.

For #744
pcorpet added a commit that referenced this issue Jan 18, 2022
@pcorpet
Adds pymongo v4 to the CI.
151e12b 
For #744
pcorpet added a commit that referenced this issue Jan 22, 2022
@pcorpet
Make pymongo v4 the default if not present.
84f218c 
For #744
pcorpet added a commit that referenced this issue Jan 22, 2022
@pcorpet
Make pymongo v4 the default if not present.
86e2cab 
Breaking Change.

For #744
pcorpet added a commit that referenced this issue Jan 23, 2022
@pcorpet
Pymongo4 migration: drop database_names, collection_names and count.
418e862 
For #744
pcorpet added a commit that referenced this issue Jan 24, 2022
@pcorpet
Pymongo4 migration: drop reindex.
17818dd 
For #744
@pcorpet pcorpet closed this as completed Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcorpet pcorpet

Labels
Work In Progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pcorpet