Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the test database rather than the test collection #601

Merged
merged 1 commit into from
Jul 30, 2020

Conversation

oorijsonar
Copy link
Contributor

Since one of the tests rename a collection (test__rename_collection) and nothing cleans it up, this test fails on the second run (pymongo.errors.OperationFailure: target namespace exists).

@codecov
Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Merging #601 into develop will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #601      +/-   ##
===========================================
- Coverage    94.69%   94.66%   -0.04%     
===========================================
  Files           16       16              
  Lines         3187     3187              
===========================================
- Hits          3018     3017       -1     
- Misses         169      170       +1     
Impacted Files Coverage Δ
mongomock/filtering.py 98.52% <0.00%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd03430...550c976. Read the comment docs.

@oorijsonar
Copy link
Contributor Author

Any idea how I managed to drop the coverage?

@pcorpet pcorpet merged commit 1e9d6c7 into mongomock:develop Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants