Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement $pop #602

Merged
merged 3 commits into from
Jul 30, 2020
Merged

Implement $pop #602

merged 3 commits into from
Jul 30, 2020

Conversation

oorijsonar
Copy link
Contributor

No description provided.

@oorijsonar oorijsonar closed this Mar 7, 2020
@oorijsonar oorijsonar reopened this Mar 7, 2020
@codecov
Copy link

codecov bot commented Mar 7, 2020

Codecov Report

Merging #602 into develop will increase coverage by 0.35%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #602      +/-   ##
===========================================
+ Coverage    94.69%   95.04%   +0.35%     
===========================================
  Files           16       17       +1     
  Lines         3187     3313     +126     
===========================================
+ Hits          3018     3149     +131     
+ Misses         169      164       -5     
Impacted Files Coverage Δ
mongomock/collection.py 92.16% <100.00%> (+0.48%) ⬆️
mongomock/filtering.py 98.56% <0.00%> (-0.34%) ⬇️
mongomock/read_concern.py 100.00% <0.00%> (ø)
mongomock/mongo_client.py 97.08% <0.00%> (+0.11%) ⬆️
mongomock/aggregate.py 97.41% <0.00%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd03430...3c4df2e. Read the comment docs.

mongomock/collection.py Show resolved Hide resolved
Copy link
Member

@pcorpet pcorpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to satisfy the CI by finalizing the test coverage.

mongomock/collection.py Show resolved Hide resolved
mongomock/collection.py Show resolved Hide resolved
@pcorpet pcorpet merged commit 28e168b into mongomock:develop Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants