Dot support for localField #603
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #603 +/- ##
========================================
Coverage 94.69% 94.70%
========================================
Files 16 16
Lines 3187 3190 +3
========================================
+ Hits 3018 3021 +3
Misses 169 169
Continue to review full report at Codecov.
|
superqwer
changed the title
superqwer
changed the title
superqwer
changed the title
mongomock/aggregate.py
Outdated
| @@ -601,6 +601,29 @@ def fixed_getter(doc): | |||
| return fixed_getter | |||
|
|
|||
|
|
|||
| def _get_local_field_val(dct, path): | |||
There was a problem hiding this comment.
Please look at helpers.get_value_by_dot and consider using it. Also please add tests for some corner cases covered by get_value_by_dot not covered by your code here.
There was a problem hiding this comment.
changed to get_value_by_dot
done
| self.assertIn( | ||
| "Although '.' is valid in the 'localField' and 'as' parameters", | ||
| str(err.exception)) | ||
| self.db.a.insert_many([ |
There was a problem hiding this comment.
Please add an equivalent test in test__mongomock to ensure that the feature is behaving the same as in pymongo
|
Changed the resolver to get_value_by_dot |
related issue #595