Project missing fields in a nested dict fix #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #605 +/- ##
========================================
Coverage 94.69% 94.69%
========================================
Files 16 16
Lines 3187 3187
========================================
Hits 3018 3018
Misses 169 169
Continue to review full report at Codecov.
|
pcorpet
requested changes
Mar 11, 2020
| @@ -3068,6 +3068,17 @@ def test__aggregate_project_missing_fields(self): | |||
| ]) | |||
| self.assertEqual([{}], list(actual)) | |||
|
|
|||
| def test__aggregate_project_missing_nested_fields(self): | |||
There was a problem hiding this comment.
Please add an equivalent test in test__mongomock to ensure the behavior is kept the same between pymongo and mongomock
|
Added similar testcase to test_mongomock |
pcorpet
approved these changes
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior of mongomock is "Ignore the whole dictionary if we couldn't find a single key"
That's not what the real mongo does
The real mongo just ignores this missing key