Fix the not exist case in $toInt and $toDecimal #612
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's the fix for the bug I mentioned in the last PR.
First, I thought it was a serious bug in
_Parse
function, so I haven't fix it in the last PR. Now, I believe it only affect the operators in the$addField
operator. So, I fix them in this PR with UTs.The case is, when we try to add a field from a field which is not exist, Mongo will return the new field with the value of None.
Now, the
$toInt
and$toDecimal
operators will return the original query now. So I return None when theKeyError
raised in these operators.If you're convenient, please review and merge it.
Cheers!