Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise a WriteError when trying to update with an empty $set. #623

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

pcorpet
Copy link
Member

@pcorpet pcorpet commented Apr 22, 2020

No description provided.

@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #623 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #623   +/-   ##
========================================
  Coverage    94.84%   94.85%           
========================================
  Files           17       17           
  Lines         3281     3284    +3     
========================================
+ Hits          3112     3115    +3     
  Misses         169      169           
Impacted Files Coverage Δ
mongomock/collection.py 91.72% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c15d173...6145a69. Read the comment docs.

Copy link
Contributor

@zozoens31 zozoens31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/test__mongomock.py Show resolved Hide resolved
@pcorpet pcorpet merged commit ca0ba31 into mongomock:develop Jun 17, 2020
@pcorpet pcorpet deleted the set-error branch June 17, 2020 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants