Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for read concern #628

Merged
merged 6 commits into from
May 23, 2020

Conversation

abarto
Copy link
Contributor

@abarto abarto commented May 22, 2020

Adds support for setting the read concern at the collection level restoring compatibility with mongoengine 0.20.

Fixes: #625

@codecov
Copy link

codecov bot commented May 22, 2020

Codecov Report

Merging #628 into develop will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #628      +/-   ##
===========================================
+ Coverage    94.76%   94.82%   +0.06%     
===========================================
  Files           16       17       +1     
  Lines         3247     3267      +20     
===========================================
+ Hits          3077     3098      +21     
+ Misses         170      169       -1     
Impacted Files Coverage Δ
mongomock/database.py 99.23% <ø> (ø)
mongomock/collection.py 91.71% <100.00%> (+0.02%) ⬆️
mongomock/read_concern.py 100.00% <100.00%> (ø)
mongomock/filtering.py 98.92% <0.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9e8d87...fa09bc4. Read the comment docs.

Copy link
Member

@pcorpet pcorpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution. Please address my comments and try to fix the CI

mongomock/read_concern.py Outdated Show resolved Hide resolved
tests/test__collection_api.py Outdated Show resolved Hide resolved
tests/test__collection_api.py Outdated Show resolved Hide resolved
tests/test__collection_api.py Show resolved Hide resolved
@abarto abarto requested a review from pcorpet May 23, 2020 12:02
@pcorpet pcorpet merged commit 49e96c6 into mongomock:develop May 23, 2020
@lsmar
Copy link

lsmar commented Jun 8, 2020

Any plans to integrate this into a release? 3.19.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mongoengine compatibility with new version 0.20.0
3 participants