Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the $regexMatch operator. #658

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Implement the $regexMatch operator. #658

merged 1 commit into from
Aug 20, 2020

Conversation

pcorpet
Copy link
Member

@pcorpet pcorpet commented Aug 13, 2020

Fix #647

@pcorpet pcorpet force-pushed the regex-match branch 3 times, most recently from f175a6d to 10d04a4 Compare August 18, 2020 21:04
@khneal khneal mentioned this pull request Aug 19, 2020
Merged
@codecov
Copy link

codecov bot commented Aug 19, 2020 •
edited

Codecov Report

Merging #658 into develop will increase coverage by 0.00%.
The diff coverage is 95.91%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #658   +/-   ##
========================================
  Coverage    95.30%   95.31%           
========================================
  Files           18       18           
  Lines         3410     3458   +48     
========================================
+ Hits          3250     3296   +46     
- Misses         160      162    +2
Impacted Files Coverage Δ
mongomock/aggregate.py 97.46% <95.91%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ca0cab...049bcde. Read the comment docs.

@pcorpet pcorpet mentioned this pull request Aug 19, 2020
Closed
gwainer
gwainer approved these changes Aug 19, 2020
View reviewed changes
Copy link

@gwainer gwainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pcorpet, looks good.

mongomock/aggregate.py Show resolved Hide resolved
@pcorpet pcorpet merged commit f4e824a into mongomock:develop Aug 20, 2020
@pcorpet pcorpet deleted the regex-match branch March 10, 2021 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kosqx kosqx kosqx left review comments

@gwainer gwainer gwainer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for '$regexMatch'
3 participants
@pcorpet @kosqx @gwainer