Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List collection names with filter #681

Merged
merged 17 commits into from
Dec 25, 2020

Conversation

hshmilov
Copy link
Contributor

@hshmilov hshmilov commented Dec 3, 2020

add filter support for list collection names
https://pymongo.readthedocs.io/en/stable/api/pymongo/database.html#pymongo.database.Database.list_collection_names

i was missing the regex support :-)
also equal and none equal are supported


This change is Reviewable

@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #681 (9feaba9) into develop (f0eb36b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #681      +/-   ##
===========================================
+ Coverage    95.41%   95.42%   +0.01%     
===========================================
  Files           19       19              
  Lines         3576     3588      +12     
===========================================
+ Hits          3412     3424      +12     
  Misses         164      164              
Impacted Files Coverage Δ
mongomock/database.py 98.54% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0eb36b...9feaba9. Read the comment docs.

Copy link
Member

@pcorpet pcorpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for adding the feature and taking the time to make all the checks pass.

mongomock/database.py Outdated Show resolved Hide resolved
mongomock/database.py Outdated Show resolved Hide resolved
mongomock/database.py Outdated Show resolved Hide resolved
mongomock/database.py Outdated Show resolved Hide resolved
mongomock/database.py Outdated Show resolved Hide resolved
mongomock/database.py Outdated Show resolved Hide resolved
mongomock/database.py Outdated Show resolved Hide resolved
tests/test__collection_api.py Outdated Show resolved Hide resolved
tests/test__collection_api.py Outdated Show resolved Hide resolved
Copy link
Member

@pcorpet pcorpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please finalize the last comments before I can merge your request.

mongomock/database.py Outdated Show resolved Hide resolved
mongomock/database.py Outdated Show resolved Hide resolved
mongomock/database.py Outdated Show resolved Hide resolved
mongomock/database.py Outdated Show resolved Hide resolved
@pcorpet pcorpet merged commit 3be39f9 into mongomock:develop Dec 25, 2020
@hshmilov
Copy link
Contributor Author

can you please generate a minor release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants