Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix use group operators in addFields #690

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

Navi6
Copy link
Contributor

@Navi6 Navi6 commented Jan 12, 2021

short PR fixing the use of grouping operators (min, max, sum and avg) used in addFields stage

@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #690 (d5eb70b) into develop (fac6470) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #690   +/-   ##
========================================
  Coverage    95.45%   95.45%           
========================================
  Files           19       19           
  Lines         3605     3606    +1     
========================================
+ Hits          3441     3442    +1     
  Misses         164      164           
Impacted Files Coverage Δ
mongomock/aggregate.py 97.56% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fac6470...d5eb70b. Read the comment docs.

@pcorpet
Copy link
Member

pcorpet commented Jan 14, 2021

Great fix, thanks.

@pcorpet pcorpet merged commit 93bf10d into mongomock:develop Jan 14, 2021
@Navi6 Navi6 deleted the fix-max-operator branch January 15, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants