Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Web UI to use WebSocket for RPC #50

Closed
rojer opened this issue Apr 14, 2020 · 9 comments
Closed

Change Web UI to use WebSocket for RPC #50

rojer opened this issue Apr 14, 2020 · 9 comments
Labels
enhancement New feature or request

Comments

@rojer
Copy link
Contributor

rojer commented Apr 14, 2020

Mongoose OS supports RPC over WebSocket.
We should open a channel and keep it open to make RPC more efficient. This will also allow regular updates of power readings and other status without sending HTTP request each time.

@rojer
Copy link
Contributor Author

rojer commented Sep 29, 2020

challenges:

  • ensure connection is re-established as necessary (e.g. when device reboots)
  • when applying new state updates, do not stomp over pending changes to fields made by the user.

@rojer
Copy link
Contributor Author

rojer commented Sep 29, 2020

https://github.com/mongoose-os-libs/wifi-setup-web-ui can be used for inspiration

@shellyrgbw
Copy link

Mongoose OS supports RPC over WebSocket.

We should open a channel and keep it open to make RPC more efficient. This will also allow regular updates of power readings and other status without sending HTTP request each time.

@shellyrgbw
Copy link

https://github.com/mongoose-os-libs/wifi-setup-web-ui can be used for inspiration

@juancitomadrid
Copy link

I can work in UI.
Let me know needs.

rojer added a commit that referenced this issue Jan 3, 2021
Change Web UI to use WebSocket for RPC (#50)
@rojer
Copy link
Contributor Author

rojer commented Jan 3, 2021

good job @ZeevoX thank you very much!
UX is much better now

@rojer rojer closed this as completed Jan 3, 2021
@andyblac
Copy link
Collaborator

andyblac commented Jan 3, 2021

@rojer any chance of beta release ?

@rojer
Copy link
Contributor Author

rojer commented Jan 3, 2021

i don't intend to cut 2.8 just for this, so we won't call it a beta, but it makes sense to cut a build that can be tested.
i think we should just have latest build always available

@rojer
Copy link
Contributor Author

rojer commented Jan 3, 2021

i filed an issue for this - #379

meanwhile, i've manually cut a one-off - http://rojer.me/files/shelly/2.7.0-latest/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants