Describe a wider branching to free the blink state

mongoose-os-libs · Oct 20, 2021 · b2ad22f · b2ad22f
1 parent 0c12abd
commit b2ad22f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/include/mgos_pcf857x.h b/include/mgos_pcf857x.h
@@ -65,7 +65,7 @@ bool mgos_pcf857x_gpio_set_button_handler(struct mgos_pcf857x *dev, int pin, enu
 
 /*
  * A utility function that takes care of blinking an LED.
- * Set to (0, 0) to disable.
+ * Set either on_ms or off_ms to 0 to disable
  */
 bool mgos_pcf857x_gpio_blink(struct mgos_pcf857x *dev, int pin, int on_ms, int off_ms);
 

diff --git a/src/mgos_pcf857x.c b/src/mgos_pcf857x.c
@@ -414,7 +414,7 @@ bool mgos_pcf857x_gpio_blink(struct mgos_pcf857x *dev, int pin, int on_ms, int o
             mgos_pcf857x_gpio_blink_cb, bs);
         res = (bs->timer_id != MGOS_INVALID_TIMER_ID);
         LD("Set timer for PIN-%d (on=%dms, off=%dms)", bs->pin, bs->on_ms, bs->off_ms);
-      } else if(on_ms == 0 && off_ms == 0) {
+      } else {
         mgos_pcf857x_clear_blink_state(bs->pin);
       }
     }