Update to be more maintainable #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file does not seem to be used anywhere, and package.json scripts are used instead
this is to not unnecessarily ship files
this is not required because eslint also uses the gitignore if existing
for consistency
Only capitalize the first letter
|
Changed from "files"-property to ".npmignore" as talked in vkarpov15/acquit-ignore#5 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does:
yarn.lockto the.gitignorefilesproperty topackage.jsonto not ship files that are not required (see unpkg)eslintrcwith a slightly modified version from current mongooseMakefilebecause only thepackage.jsonscripts seem to be used noweslintignorefile, because eslint also uses thegitignorefile (which contains what theeslintignorefile also includes)