Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using dockerd as docker daemon has been deprecated #24

Merged
merged 1 commit into from
Mar 20, 2018

Conversation

ageekymonk
Copy link
Contributor

Fix for #22

@mongrelion
Copy link
Owner

@marcusianlevine before you merge this could you please make sure that it doesn't break any previous supported version that we offer?
I know this sucks to have to manually test this. We really need those integration tests ;_;

@marcusianlevine
Copy link
Collaborator

marcusianlevine commented Nov 26, 2017

I ran the build locally and everything worked fine, but as-is this change will break backwards compatibility with versions of Docker <1.13

Do we intend to support 1.12 and below? For reference, Rancher's setup scripts support down to 1.10

If so, we need to add a conditional that checks the Docker version and decides which daemon command to use.

@mongrelion mongrelion merged commit d03e3c2 into mongrelion:master Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants