Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow install docker also on RHEL OS #53

Merged
merged 1 commit into from
Jun 19, 2018

Conversation

petr-balogh
Copy link
Contributor

This alow install docker-ce also on RHEL OS.
Tested on RHEL 7.5

This alow install docker-ce also on RHEL OS.
Tested on RHEL 7.5
@paulfantom paulfantom merged commit 4f40e8d into mongrelion:master Jun 19, 2018
@petr-balogh
Copy link
Contributor Author

Hi and thx, are you going to make new release to have this change available in galaxy?

@paulfantom
Copy link
Collaborator

Not today, but soon.

@petr-balogh
Copy link
Contributor Author

petr-balogh commented Jun 19, 2018 via email

@mongrelion
Copy link
Owner

Thanks for the PR, @petr-balogh and to @paulfantom for reviewing.
A couple of things that I see missing here that I would have liked to see before merging a pull request like this (but bear with me if I'm missing something, please):

  1. I don't see the tests for this but maybe since we already support CentOS, it's already covered for RedHat as well?
  2. I also don't see an update on the meta to let everyone know that we now support RedHat. Is that also covered by EL/7?

Thanks for the effort, everyone.

@paulfantom
Copy link
Collaborator

  1. CentOS tests cover also RHEL.
  2. There is no specific meta for RHEL it is covered by EL/7

@mongrelion
Copy link
Owner

Thanks for clarifying.

@paulfantom
Copy link
Collaborator

No problem 😄

Sorry for the confusion

@paulfantom
Copy link
Collaborator

Fun fact, docker basically doesn't have any official builds of docker-ce for RHEL (https://docs.docker.com/install/#server) and they want everybody to use docker-ee on that OS (installation insctruction for RHEL)

Also https://blog.docker.com/2017/03/docker-enterprise-edition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants