This repository has been archived by the owner on Jun 8, 2023. It is now read-only.
refactor: manage address vault wide #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndler into 2023-01-13-refactor-address
…ndler into 2023-01-13-refactor-address
|
Kudos, SonarCloud Quality Gate passed! |
asbiin
approved these changes
Jan 17, 2023
asbiin
pushed a commit
to monicahq/monica
that referenced
this pull request
Mar 31, 2023
asbiin
pushed a commit
to monicahq/monica
that referenced
this pull request
May 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, addresses are linked to contacts. However many more objects need an address: Company, Life Event, etc..
We need to associate addresses to vaults, not contacts.
This also will solve somewhat the use case described in #341 , as well as #408