Skip to content
This repository has been archived by the owner on Jun 8, 2023. It is now read-only.

feat: list all addresses in vault #422

Merged
merged 13 commits into from
Feb 9, 2023
Merged

feat: list all addresses in vault #422

merged 13 commits into from
Feb 9, 2023

Conversation

djaiss
Copy link
Member

@djaiss djaiss commented Feb 6, 2023 •
edited

Close #413

This PR

  • rewrites the Address module using setup script of Vue 3
  • adds a new Report tab that shows all the countries and cities used in the vault
  • grabs information from Wikipedia when viewing a country or a city
  • changes the behaviour of deleting an address: if no other contact uses an address, we delete the address entirely.

@djaiss djaiss added the draft label Feb 6, 2023
@djaiss djaiss requested a review from asbiin February 7, 2023 02:06
@djaiss djaiss marked this pull request as ready for review February 7, 2023 02:11
@djaiss djaiss mentioned this pull request Feb 7, 2023
Open
asbiin
asbiin suggested changes Feb 8, 2023
View reviewed changes
Copy link
Member

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments

app/Domains/Vault/ManageReports/Web/ViewHelpers/ReportAddressIndexViewHelper.php Show resolved Hide resolved
app/Helpers/WikipediaHelper.php Show resolved Hide resolved
app/Helpers/WikipediaHelper.php Outdated Show resolved Hide resolved
resources/js/Shared/Modules/Addresses.vue Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Feb 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

82.6% 82.6% Coverage
0.0% 0.0% Duplication

@djaiss djaiss mentioned this pull request Feb 9, 2023
Open
@djaiss djaiss merged commit ee17e9a into main Feb 9, 2023
@djaiss djaiss deleted the 2023-02-05-address-vaults branch February 9, 2023 13:06
asbiin pushed a commit to monicahq/monica that referenced this pull request Mar 31, 2023
@djaiss @asbiin
feat: list all addresses in vault (monicahq/chandler#422)
b7734ce
asbiin pushed a commit to monicahq/monica that referenced this pull request May 29, 2023
@djaiss
feat: list all addresses in vault (monicahq/chandler#422)
9281ffc
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@asbiin asbiin asbiin requested changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

List all the addresses used in a vault
2 participants
@djaiss @asbiin