Skip to content
This repository has been archived by the owner on Jun 8, 2023. It is now read-only.

feat: life metrics #462

Merged
merged 17 commits into from May 5, 2023
Merged

feat: life metrics #462

merged 17 commits into from May 5, 2023

Conversation

djaiss
Copy link
Member

@djaiss djaiss commented Apr 1, 2023

image

A life metric is something that you want to track, like how many times you've watched Netflix in the year, for instance.

It's a simple counter that lets you +1.

We will attach it to the journal in a future iteration.

It also displays a graph (in CSS) when we click on the numbers.

image

@djaiss djaiss added the draft label Apr 1, 2023
@djaiss djaiss marked this pull request as ready for review April 3, 2023 18:15
@djaiss djaiss requested a review from asbiin April 10, 2023 23:57
asbiin
asbiin previously requested changes Apr 19, 2023
Copy link
Member

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! some remarks though ...

resources/css/app.css Show resolved Hide resolved
resources/js/Pages/Vault/Dashboard/Index.vue Outdated Show resolved Hide resolved
resources/js/Pages/Vault/Dashboard/Index.vue Outdated Show resolved Hide resolved
@djaiss djaiss enabled auto-merge (squash) May 5, 2023 14:29
@sonarcloud
Copy link

sonarcloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.4% 75.4% Coverage
0.0% 0.0% Duplication

@djaiss djaiss merged commit 3fb81a2 into main May 5, 2023
17 checks passed
@djaiss djaiss deleted the 2023-03-31-life-metrics branch May 5, 2023 14:36
asbiin pushed a commit to monicahq/monica that referenced this pull request May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants