fix: storage_limit can be unlimited (#6989)

monicahq · Oct 31, 2023 · a75643a · a75643a
1 parent 0e4d192
commit a75643a
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/app/Helpers/StorageHelper.php b/app/Helpers/StorageHelper.php
@@ -14,6 +14,11 @@ class StorageHelper
      */
     public static function canUploadFile(Account $account): bool
     {
+        // if storage limit is 0 then unlimited storage is allowed
+        // therefore the function should always return true
+        if ($account->storage_limit_in_mb == 0) {
+            return true;
+        }
         // get the file size of all the files in the account
         // the size will be in bytes
         $vaultIds = $account->vaults()->select('id')->get()->toArray();

diff --git a/tests/Unit/Helpers/StorageHelperTest.php b/tests/Unit/Helpers/StorageHelperTest.php
@@ -32,4 +32,24 @@ public function it_checks_if_we_can_upload_another_file_in_the_account(): void
 
         $this->assertFalse(StorageHelper::canUploadFile($account));
     }
+
+    /** @test */
+    public function it_checks_if_we_can_upload_files_with_0_storage_limit(): void
+    {
+        $account = Account::factory()->create([
+            'storage_limit_in_mb' => 0,
+        ]);
+
+        $this->assertTrue(StorageHelper::canUploadFile($account));
+
+        $vault = Vault::factory()->create([
+            'account_id' => $account->id,
+        ]);
+        File::factory()->create([
+            'vault_id' => $vault->id,
+            'size' => 1024 * 1024,
+        ]);
+
+        $this->assertTrue(StorageHelper::canUploadFile($account));
+    }
 }