fix: fix webauthn login (#7222)

app/Actions/Fortify/RedirectIfTwoFactorAuthenticatable.php

@@ -16,8 +16,6 @@ class RedirectIfTwoFactorAuthenticatable
 {
     /**
      * Create a new action instance.
-     *
-     * @return void
      */
     public function __construct(
         protected StatefulGuard $guard,
@@ -27,10 +25,8 @@ public function __construct(
 
     /**
      * Handle the incoming request.
-     *
-     * @return mixed
      */
-    public function handle(Request $request, Closure $next)
+    public function handle(Request $request, Closure $next): mixed
     {
         $user = $this->validateCredentials($request);
 
@@ -59,7 +55,6 @@ protected function validateCredentials(Request $request): ?User
     /**
      * Throw a failed authentication validation exception.
      *
-     *
      * @throws \Illuminate\Validation\ValidationException
      */
     protected function throwFailedAuthenticationException(Request $request): void
@@ -91,7 +86,7 @@ protected function twoFactorChallengeResponse(Request $request, ?User $user)
     {
         $request->session()->put([
             'login.id' => $user->getKey(),
-            'login.remember' => $request->filled('remember'),
+            'login.remember' => $request->boolean('remember'),
         ]);
 
         TwoFactorAuthenticationChallenged::dispatch($user);

app/Providers/FortifyServiceProvider.php

@@ -3,7 +3,6 @@
 namespace App\Providers;
 
 use App\Actions\Fortify\CreateNewUser;
-use App\Actions\Fortify\RedirectIfTwoFactorAuthenticatable;
 use App\Actions\Fortify\ResetUserPassword;
 use App\Actions\Fortify\TwoFactorChallengeView;
 use App\Actions\Fortify\UpdateUserPassword;
@@ -14,8 +13,6 @@
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\RateLimiter;
 use Illuminate\Support\ServiceProvider;
-use Laravel\Fortify\Actions\AttemptToAuthenticate;
-use Laravel\Fortify\Actions\PrepareAuthenticatedSession;
 use Laravel\Fortify\Fortify;
 
 class FortifyServiceProvider extends ServiceProvider
@@ -37,12 +34,6 @@ public function register()
      */
     public function boot()
     {
-        Fortify::authenticateThrough(fn () => [
-            RedirectIfTwoFactorAuthenticatable::class,
-            AttemptToAuthenticate::class,
-            PrepareAuthenticatedSession::class,
-        ]);
-
         Fortify::loginView(fn ($request) => (new LoginController())($request));
         Fortify::confirmPasswordsUsing(fn ($user, ?string $password = null) => $user->password
                 ? app(StatefulGuard::class)->validate([

composer.json

@@ -13,7 +13,7 @@
     "php": "^8.2",
     "ext-fileinfo": "*",
     "asbiin/laravel-sentry-tunnel": "^2.0",
-    "asbiin/laravel-webauthn": "^4.0",
+    "asbiin/laravel-webauthn": "^4.4",
     "codezero/laravel-localizer": "^3.0",
     "doctrine/dbal": "^3.6",
     "guzzlehttp/guzzle": "^7.4",

config/fortify.php

@@ -142,4 +142,11 @@
         ]),
     ],
 
+    'pipelines' => [
+        'login' => [
+            \App\Actions\Fortify\RedirectIfTwoFactorAuthenticatable::class,
+            \Laravel\Fortify\Actions\AttemptToAuthenticate::class,
+            \Laravel\Fortify\Actions\PrepareAuthenticatedSession::class,
+        ],
+    ],
 ];