Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show total number of participants in events #4204

Closed
lydgate opened this issue Jul 1, 2020 · 4 comments · Fixed by #5474
Closed

Show total number of participants in events #4204

lydgate opened this issue Jul 1, 2020 · 4 comments · Fixed by #5474

Comments

@lydgate
Copy link

lydgate commented Jul 1, 2020

Is your feature request related to a problem? Please describe.

I run events, and it would be very nice (after adding all participants to the activity) to see a total number of how many people attended. I thought it should be trivial to just put it in parentheses after "Participants" but before the linked list of names.

Describe the solution you'd like
Just for it to look like: "Participants (10): Person 1 Person 2...Person 10"

Describe alternatives you've considered (optional)

I suppose select * from activity_contact where activity_id=x will also work but that requires a bit of effort :)

Additional context

This is from the list of activities on the contact page. It might also make sense to show it on the edit list but I'm not sure.

@MarkusDick
Copy link

MarkusDick commented Aug 26, 2021

Hello guys :)
I would like to work on this issue.
This would be my first contribution to this project. This issue seems to be fixed by a little change in the localization file resources/lang/en/people.php and the resources/js/components/people/activity/ActivityList.vue.

I would add a count variable to the variable activities_list_participants in the localization file and use the property activity.attendees.total in the ActivityList.vue file to display the count of the participants.
I would reduce the count by one, because in the array also the contact itself is indicated, but not in the displayed list.

@djaiss This change would affect the appearance of the UI a little bit. Is it ok if it will look like above described: Participants (10): Person 1 Person 2...Person 10?

Best regards
Markus

@github-actions
Copy link

github-actions bot commented Oct 9, 2021

🎉 This issue has been resolved in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lydgate
Copy link
Author

lydgate commented Oct 18, 2021

Thank you so much for implementing this! It is very handy. However I think it ends up with n-1 participants, possibly not including the person whose page you are viewing? Or have I confused myself...

@github-actions
Copy link

This issue has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants