Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a way to do functional tests #698

Closed
djaiss opened this issue Dec 14, 2017 · 12 comments · Fixed by #796
Closed

Find a way to do functional tests #698

djaiss opened this issue Dec 14, 2017 · 12 comments · Fixed by #796
Assignees

Comments

@djaiss
Copy link
Member

djaiss commented Dec 14, 2017

We use unit tests and some sort of functional tests, but these are extremely limited.

I've done some tests with Dusk but

  • tests with Dusk are painfully slow
  • they don't work with Homestead (or the installation process is horribly painful)

What can we use to do functional tests? I'd love to use Ghost Inspector which is a company I've always admired, but

  • they are expensive and the project earns like nothing today
  • adding tests could be done only by a few people (including me) and not people who submit PRs.

Functional testing is a necessity and not having them currently makes me super nervous.

@djaiss
Copy link
Member Author

djaiss commented Dec 21, 2017

Perhaps Dusk is the answer after all. Even if I don't like its slowness. It doesn't work with Homestead, but it does work when your dev env is outside a VM (with Valet for instance).

An avenue to run Dusk on Travis https://laravel-news.com/laravel-dusk-continuous-integration

@erdmenchen
Copy link

What exactly are you missing from default Laravel http testing capabilities?

@asbiin
Copy link
Member

asbiin commented Jan 10, 2018

I'm currently trying to run tests with an other test framework which uses selenium : lmc/steward.

@asbiin asbiin self-assigned this Jan 11, 2018
@djaiss
Copy link
Member Author

djaiss commented Jan 11, 2018

@erdmenchen it won't let me test the views that contain VueJS.

@erdmenchen
Copy link

What about this approach: https://nick-basile.com/blog/post/testing-a-vuejs-and-laravel-todo-app

The author uses PHPunit tests for Laravel side by side with the official vue-test-utils for your vue stuff...

And a key motivation was speed, too.

@djaiss
Copy link
Member Author

djaiss commented Jan 11, 2018

@erdmenchen Wasn't aware of this. It's worth trying so we can stick with Laravel's built-in capabilities. Will test and report.

@erdmenchen
Copy link

Why close? Is the discussion over?

@asbiin
Copy link
Member

asbiin commented Jan 14, 2018

Well, this was closed automatically when I've merged the PR, but the discussion is not really over, yep !

@asbiin asbiin reopened this Jan 14, 2018
@asbiin
Copy link
Member

asbiin commented Feb 19, 2018

The (merged) PR #892 activated tests with Dusk.

@djaiss
Copy link
Member Author

djaiss commented Feb 20, 2018

So yes, we've migrated to Dusk outside a VM, we run it on Sauce Labs and for now, things are working. We should see if we encounter cases where Dusk is not appropriate again.

@asbiin
Copy link
Member

asbiin commented Mar 20, 2018

Browser tests are running well now.

@asbiin asbiin closed this as completed Mar 20, 2018
@github-actions
Copy link

This issue has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants