Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix subscription cancel on account deletion #1749

Merged
merged 6 commits into from
Aug 31, 2018
Merged

fix: fix subscription cancel on account deletion #1749

merged 6 commits into from
Aug 31, 2018

Conversation

asbiin
Copy link
Member

@asbiin asbiin commented Aug 28, 2018

This should fix #1680

@djaiss
Copy link
Member

djaiss commented Aug 29, 2018

@asbiin on 🔥

@asbiin
Copy link
Member Author

asbiin commented Aug 29, 2018

This line was surprising: auth()->user()->has_access_to_paid_version_for_free == 0 as the proprerty is on Account, not on User.

@djaiss
Copy link
Member

djaiss commented Aug 29, 2018

@asbiin indeed. I was on drug at this time, probably.

@asbiin asbiin merged commit b433b45 into master Aug 31, 2018
@asbiin asbiin deleted the fix/account-delete branch August 31, 2018 19:46
@github-actions
Copy link

github-actions bot commented Feb 2, 2021

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ErrorException: Trying to get property 'name' of non-object
2 participants
@asbiin @djaiss