feat: add contact archiving #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaiss
requested changes
Sep 3, 2018
CHANGELOG
Outdated
| @@ -14,6 +14,7 @@ UNRELEASED CHANGES: | |||
| * Fix gift recipient relation | |||
| * Fix subscription cancel on account deletion | |||
| * Fix email maximum size on settings | |||
| * Add contact archiving | |||
| <div> | ||
| <notifications group="archive" position="top middle" duration=5000 width="400" /> | ||
|
|
||
| <a href="#" class="btn edit-information" @click="toggle">{{ active ? $t('people.contact_archive') : $t('people.contact_unarchive') }}</a> |
There was a problem hiding this comment.
I think you can simply omit href="#" entirely.
djaiss
reviewed
Sep 5, 2018
resources/lang/en/people.php
Outdated
| @@ -63,6 +63,7 @@ | |||
| 'edit_contact_information' => 'Edit contact information', | |||
| 'contact_archive' => 'Archive contact', | |||
| 'contact_unarchive' => 'Unarchive contact', | |||
| 'contact_archive_help' => 'Archived contact will not appear on contact lists', | |||
There was a problem hiding this comment.
Archived contacts will not be shown in the contact list
|
Don't forget to run Cypress on this one. |
|
@djaiss cypress fails on my computer on master branch: I cannot validates any modification with it. |
djaiss
approved these changes
Oct 27, 2018
|
I've rewritten some of the screens, also removed the button and use a link instead. |
![sonarcloud[bot]](https://avatars.githubusercontent.com/in/12526?s=60&v=4){kind=small}
|
This pull request has been automatically locked since there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This close #1623
(Add api functions to get archived contacts => this one will be done in another PR)