chore: fix vuejs v-if and v-else usages #1888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@asbiin this is a dangerous change. We need to test it thoroughly for each one of those changes. I’ll help you testing that. Because I’m sure we’ve broken some stuff here. |
|
@djaiss it's pure vuejs logic. Don't you believe it can works? ;) |
|
@asbiin two errors on Cypress 😀 One in Activity Types in the Settings, the other when managing a task. I don't have time tonight but I can help to check what's going on. |
|
@djaiss I also had bizarre error in adding a life event... |
This was referenced Oct 30, 2018
Merged
|
This pull request has been automatically locked since there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not modify any feature