Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prefix for table names (DB_PREFIX) is now working #1938

Merged
merged 12 commits into from
Oct 28, 2018

Conversation

bdowson
Copy link

@bdowson bdowson commented Oct 23, 2018

Setting DB_PREFIX in your .env file will now create the appropriate tables and work as expected.

Fix for: #1896

@bdowson
Copy link
Author

bdowson commented Oct 24, 2018

Unsure why this is failing the continuous-integration/styleci/pr test, if you look at the code that I actually committed it is not the same as what is being shown in continuous-integration/styleci/pr 😄

Copy link
Member

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thanks.
The original code of these 2 changes seems good. Can you explain why it needs a rewrite?

app/Console/Commands/Update.php Show resolved Hide resolved
@asbiin asbiin merged commit dc21d00 into monicahq:master Oct 28, 2018
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants