docs: add basic SSL documentation #1997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@allanlw That is just awesome! Nothing to add. |
|
@djaiss fill free to re-read the document. |
|
This is awesome. I was thinking about submitting a PR to add these details but you got to it first and wrote something much more comprehensive. Thanks for adding this! I could definitely have used it a few days ago. |
Co-Authored-By: allanlw <wirtha@bu.edu>
Co-Authored-By: allanlw <wirtha@bu.edu>
Co-Authored-By: allanlw <wirtha@bu.edu>
asbiin
approved these changes
Nov 11, 2018
This was referenced Nov 13, 2018
Closed
|
This pull request has been automatically locked since there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSL termination seems to be a frequent source of confusion for new users/installers. I know it was for me personally, and I found a plethora of issues asking questions about this when I searched (#479, #679, #835, #1287, #1535).
This adds a new file in
docs/installationcalledssl.mdthat has some information about how to configure Monica to use HTTPS, including information about the APP_ENV=production implication, the role of the "TRUSTED_PROXIES" and an example nginx and docker compose file for performing TLS termination in a separate docker container with the official docker container running unmodified.