feat: add ability to indicate the number of contacts in seeders #3585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaiss
changed the title
|
Oh great, it's been a long time I wanted to do this 😊 |
|
SonarCloud Quality Gate failed.
|
|
This pull request has been automatically locked since there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to specify the number of contacts that are generated using the seeder for tests account. Before, we only had between 60 and 100 contacts in a test account. Now, with this change, you can have any number of contacts.
Because we need to ask for the number of contacts, we should run the FakeContentTableSeeder in a command.
This is why all the code from FakeContentTableSeeder has been moved to the SetupTest command.
@asbiin this is an important change, but not a complex one.