Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-game analysis on server returns multiple winning hands on high-card result #8

Closed
monicanagent opened this issue Nov 20, 2018 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@monicanagent
Copy link
Owner

When a player has a high-card hand result as the highest ranking winning hand, multiple hands appear for that player in the contract's post-game analysis.

A similar issue appeared in the client-side analyzer.

Although this doesn't appear to cause an issue with winnings distribution, it should nevertheless be limited to a single result.

@monicanagent monicanagent added the bug Something isn't working label Nov 20, 2018
@monicanagent monicanagent added this to the v0.2.3 milestone Nov 20, 2018
@monicanagent monicanagent self-assigned this Nov 20, 2018
@monicanagent monicanagent added this to To do in CypherPoker.JS via automation Nov 20, 2018
@monicanagent monicanagent modified the milestones: v0.2.3, v0.3.0 Nov 23, 2018
@monicanagent
Copy link
Owner Author

Moved to 0.3.0 milestone

@monicanagent
Copy link
Owner Author

Updated in commit 86d03b0

As with the client-side analyzer, the hand scoring mechanism in the smart contract interface grouped highest-ranking hands together in order to accommodate ties (more than one winner). For some hands, however, such as high cards, the highest hand score would appear in multiple permutations for the same player and therefore be repeated.

Hands are now filtered so that only one highest ranking hand is stored per player if more than one appears.

CypherPoker.JS automation moved this from To do to Done Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

1 participant