Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: change brightness/volume for all displays, including internal #14

Closed
Amir-Hass opened this issue Feb 18, 2018 · 10 comments · Fixed by #175
Closed

Feature: change brightness/volume for all displays, including internal #14

Amir-Hass opened this issue Feb 18, 2018 · 10 comments · Fixed by #175
Assignees
Labels
Priority: Minor Issue is minor (e.g. Monitor or cable type specific…) Type: Enhancement Issue is an app enhancement

Comments

@Amir-Hass
Copy link

Amir-Hass commented Feb 18, 2018

The setting to change brightness and volume at the same time for all displays doesn't work. This happens both with the keyboard shortcut and the menu bar widget, they only do one display at a time. (version 1.2)

@the0neyouseek the0neyouseek self-assigned this Feb 18, 2018
@the0neyouseek the0neyouseek added the Type: Bug Issue is a bug (e.g. Crash, …) label Feb 18, 2018
@the0neyouseek
Copy link
Member

Hi again @Amir-Hass ,

Thank you for testing this, as I currently don't have a multi-monitor setup I couldn't test it well. I'll try to see if I can find another monitor to squash this bug soon.

Have a nice day !

@the0neyouseek the0neyouseek added this to the Version 1.3 milestone Feb 20, 2018
@funbben
Copy link

funbben commented Feb 22, 2018

I confirm it doesn't work, changing brightness/contrast with sliders works fine, for external monitor but doesn't work for internal display.

@the0neyouseek the0neyouseek added Type: Enhancement Issue is an app enhancement and removed Type: Bug Issue is a bug (e.g. Crash, …) labels Feb 25, 2018
@the0neyouseek
Copy link
Member

Hi @funbben ,

Actually, this was not what I had in mind with this option. MonitorControl doesn't handle at all the internal display, so the settings should only affect (in theory since I haven't tested it) external display for now.

But as it's a very good suggestion I'll had this to the list of things to do. (Maybe as a separate setting for example)

@marcelfarres
Copy link

I would love to be able to control internal+external brightness together.

@cseelus
Copy link

cseelus commented Jun 14, 2018

@the0neyouseek Maybe you could use code from Brightness Menulet to achieve this.

Brightness Menulet sets the brightness for the internal screen as well.

One thing thats really convenient, is the option to follow the main screens (internal screens) brightness, which dims/brightens the external display automatically with the internal display, when the ambient light sensor of the iMac/MacBook detects changes there.

@retrography
Copy link

@cseelus: Your excellent idea is being explored here: #27.

@retrography
Copy link

retrography commented Jun 18, 2018

The idea of controlling the internal monitor along with the external is great. It has some caveats, though:

  1. The grading (or gradient) of the brightness control is not always the same between the internal and the external. My understanding is that my external monitor has a more linear grading while the internal MacBook monitor seems to follow a more "visual" logic.
  2. The minimums are not the same.The internal monitor literally turns the backlight off when the brightness hits 0. The external, never.
  3. The maximums are not the same. My internal monitor (on 2016 Pro) has 500 nits, while my external ones only have 300 and 350.

So, a locking solution needs to consider this, and yes, it will be absolutely worth the pain to do so. This is an excellent feature.

I would also gladly have the same locking solution for the volume. The same caveats apply to the volume level.

@cseelus
Copy link

cseelus commented Jun 18, 2018

Hi, @retrography , thanks for getting back

  1. To get the grading to match will be very difficult I think, I don't know if this will be doable and necessary
  2. Brightness Menulet has settings for the min-max values, which work quite well, at least for my setup (MBP 13" 2017 & Dell U2715H
    screen shot 2018-06-18 at 14 02 04
  3. See 2.

I can't say much about the volume settings though, as I only use Headphones (via TB3-Dock) or a pair of Speakers via Bluetooth.

@the0neyouseek the0neyouseek changed the title Change Brightness/Volume for all displays setting does not work Feature: change brightness/volume for all displays, including internal May 23, 2019
@the0neyouseek the0neyouseek added the Priority: Minor Issue is minor (e.g. Monitor or cable type specific…) label May 23, 2019
@the0neyouseek the0neyouseek removed this from the Version 1.4 milestone May 23, 2019
@yedlosh
Copy link

yedlosh commented Nov 28, 2019

Well I had tried the Brightness Menulet because of this, and it's Follow Main Screen option works great for me, but the app has a bug that only one of my two identical monitors gets controlled, and it's apparently not supported anymore. So yeah.. It's a shame there still isn't one DDC app which has everything working.

@JoniVR
Copy link
Member

JoniVR commented Jan 26, 2020

I'm working on this in #148, I'm going to try to make it respect the "Change brightness/volume for all displays" checkbox and allow the user to select it from the display preferences.

Not 100% sure how well it would work since talking to the internal display requires the usage of another (private) api, the same one other brightness tools use. Tracking progress mostly in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Minor Issue is minor (e.g. Monitor or cable type specific…) Type: Enhancement Issue is an app enhancement
Projects
None yet
8 participants