-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ctrl + F1/F2 should change the internal monitor's brightness #148
Comments
I'd also like some way to control brightness of the internal display when using MonitorControl with an external monitor. |
Right now I am using this one instead of MonitorControl to achieve that: It has no UI, it's not supported anymore, but it simply controls brightness of all my external monitors at once using F1/F2. Which is actually everything I needed. So Fn keys remain free to control internal display, and F1/F2 (for me actually Fn+F1/F2) control the external ones.. and it just works 👍 |
This would allow us to more easily control the built-in display. Allowing for easier implementation of certain feature requests (for example #148).
This is something that I plan on adding together with #118 but it requires a lot of rewriting under the hood.. and I'm very limited in time. I made some of the first steps in previous commit linked here (46d7cb6) rewriting the display managing logic. The project was long overdue for some refactoring of the display logic anyways.. |
* Split `Display` into `InternalDisplay` and `ExternalDisplay` * Add functions for controlling internal display brightness * Refactor `DisplayManager` (#148)
Most of the code refactor is done, the internal display respects the Just waiting for MonitorControl/MediaKeyTap#5 to be reviewed/merged right now. After that I'll do a few more final things and open a PR for review. |
@JoniVR Merged 😉 |
Pull Request has been submitted! For the people that know how to, please feel free to test/review it and report any issues since a lot of the display logic has changed, there's always a bigger chance of introducing new issues. It's pretty hard to test with only one configuration so the more people that test it the better. |
This is the default behaviour on Apple monitors.
The text was updated successfully, but these errors were encountered: