Fix the test breakage introduced in #29 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
brancz
approved these changes
Jan 4, 2021
|
Thanks @tomwilkie for fixing the test. I added the test originally to verify that you could download the whole catalogue correctly, but I agree with you in that we shouldn't couple mixtool with all the mixins. Perhaps this test is unnecessary then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tom Wilkie tom.wilkie@gmail.com
I'm not sure these tests (downloading & building all the mixins in the catalogue) are a good idea, they're more likely to break when a mixin breaks than when mixtool breaks IMO. But I've fixed the test for now, we can debate that later.
/cc @allenmqcymp