check_ntp_time: Bug in average calculation [sf#2993229]

[monitoring-user]

Submitted by larsi- on 2010-04-27 23:08:10

Hello Nagios-Plugins Team,

attached you can find a patch which applies to current check_ntp_time. The bug was found by Mathias Kettner.

The patch contains the following changes:

1. A minor change which makes the AVG_NUM configurable by compiler define.
2. The more important change: A fix for a bug which caused the check_ntp_time check to always take the first response from ntp and not the avarage since "j" is not increased anywhere. "i" should be used there instead.

Kind regards,
Lars

--- check_ntp_time.c.orig 2010-04-27 12:08:08.000000000 +0000
+++ check_ntp_time.c 2010-04-27 12:13:23.000000000 +0000
@@ -55,7 +55,9 @@
void print_usage (void);

/* number of times to perform each request to get a good average. */
+#ifndef AVG_NUM
#define AVG_NUM 4
+#endif

/* max size of control message data /
#define MAX_CM_SIZE 468
@@ -422,7 +424,7 @@
} else {
/ finally, calculate the average offset */
for(i=0; i<servers[best_index].num_responses;i++){

•       avg_offset+=servers[best_index].offset[j];
  

•       avg_offset+=servers[best_index].offset[i];
  }
  avg_offset/=servers[best_index].num_responses;
  

  }