use FindBin instead of awk to find the path to utils.pm #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'use lib utils.pm' is not valid Perl syntax: Bareword "utils" not allowed while "strict subs" in use at plugins-scripts/check_ircd.pl line 52. Bareword "pm" not allowed while "strict subs" in use at plugins-scripts/check_ircd.pl line 52. This makes it impossible to use the plugins directly from the git tree, e.g. while hacking on them. Using FindBin::Bin as the library path allows that, while preserving the original behaviour of adding the libexec path when the plugin is properly installed.
|
Thinking further, the following can now be removed from Removing this would stop new contributions from accidentally using it again. The whole |
It was only used to replace the 'use lib utils.pm' with the proper libexec dir, which is now solved by using Perl's FinBin.
mat813
pushed a commit
to Absolight/monitoring-plugins
that referenced
this pull request
Sep 13, 2017
It was only used to replace the 'use lib utils.pm' with the proper libexec dir, which is now solved by using Perl's FinBin. Closes monitoring-plugins#1241
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'use lib utils.pm' is not valid Perl syntax:
This makes it impossible to use the plugins directly from the git tree, e.g. while hacking on them.
Using
FindBin::Binas the library path allows that, while preserving the original behaviour of adding thelibexecpath when the plugin is properly installed.