Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_http: add check for virtual port usage #1444

Closed
wants to merge 0 commits into from
Closed

check_http: add check for virtual port usage #1444

wants to merge 0 commits into from

Conversation

odenbach
Copy link
Contributor

Hi,

I just added a test for virtual port usage:

./check_http -H 127.0.0.1 -p 50637 -u /virtual_port

will fail, while

./check_http -H 127.0.0.1:80 -p 50637 -u /virtual_port

will succeed.

Any Comments?

Thanks,

Christopher

@waja
Copy link
Member

waja commented Nov 16, 2016

Hi @odenbach,

thanks for sharing. A small side note:

Please do not make changes to the master branch of your fork but create a own branch for every fix/feature/contribution. Otherwise you/we/all will end up into a mess.

Thanks and cheers, Jan.

@sni
Copy link
Contributor

sni commented Nov 17, 2016

Also please do not change existing tests, like the "run_common_tests" unless neccessary. I think its better to add new tests along the existing ones.
Also i added some tests last week with 9e02d0c. Does this PR add different checks?

@odenbach odenbach closed this Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants