Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issue with MariaDB 10.2 #1522

Merged
merged 1 commit into from Oct 22, 2018

Conversation

Sp1l
Copy link
Contributor

@Sp1l Sp1l commented Nov 6, 2017

As of 10.2 MariaDB no longer defines MYSQL_PORT.

As of 10.2 MariaDB no longer defines MYSQL_PORT.
@waja
Copy link
Member

waja commented Nov 7, 2017

Potential fix for #1508

Copy link
Contributor

@sni sni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@sni sni merged commit 1c0a48b into monitoring-plugins:master Oct 22, 2018
@sni
Copy link
Contributor

sni commented Oct 22, 2018

thanks

@waja
Copy link
Member

waja commented Jan 15, 2019

Is there a chance to get that also merged into maint-2.2? ;)

@ottok
Copy link

ottok commented Jan 18, 2019

This has also been encountered in Debian, see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=919375

i686-linux-gnu-gcc -DLOCALEDIR=\"/usr/share/locale\" -DHAVE_CONFIG_H -I. -I..  -I.. -I../lib -I../gl -I../intl -I/usr/include/ldap -I/usr/include/postgresql -I/usr/include -I/usr/include/mariadb -I/usr/include/ma
riadb/mysql -Wdate-time -D_FORTIFY_SOURCE=2 -DNP_VERSION='"2.2"' -I/usr/include/mariadb -I/usr/include/mariadb/mysql -g -O2 -fdebug-prefix-map=/build/monitoring-plugins-2.2=. -fstack-protector-strong -Wformat -We
rror=format-security -Wall -Wl,-z,now -MT check_mysql-check_mysql.o -MD -MP -MF .deps/check_mysql-check_mysql.Tpo -c -o check_mysql-check_mysql.o `test -f 'check_mysql.c' || echo './'`check_mysql.c
check_mysql.c:61:24: error: 'MYSQL_PORT' undeclared here (not in a function); did you mean 'MYSQL_STMT'?
 unsigned int db_port = MYSQL_PORT;
                        ^~~~~~~~~~
                        MYSQL_STMT
make[3]: *** [Makefile:1869: check_mysql-check_mysql.o] Error 1

If this PR was also merged on the maint-2.2 branch as suggested above, it would be fixed upstream and soon automatically in Debian as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants