Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_http: Fixing unchunking body when no body is present #1901

Merged

Conversation

trickert76
Copy link
Contributor

When no-body is enabled and the server responses with a chunked body, there is always an unknown response from check_http because it tries to read the body, which is not present.

@waja waja changed the title Fix issue #1872 check_http: Fixing unchunking body when no body is present Aug 9, 2023
@waja waja added the check_http label Aug 9, 2023
Copy link
Member

@RincewindsHat RincewindsHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you very much.

@RincewindsHat RincewindsHat merged commit 0613648 into monitoring-plugins:master Sep 7, 2023
4 checks passed
@paladox
Copy link

paladox commented Oct 19, 2023

Is there any chance this could be backported to https://packages.debian.org/bookworm/monitoring-plugins?

@RincewindsHat
Copy link
Member

Hi @paladox, maybe waja is interested to do that. Otherwise just use check_curl which does the same as check_http but better.

@paladox
Copy link

paladox commented Oct 19, 2023

Thanks! Switched to check_curl and seems to fix it for me.

@waja
Copy link
Member

waja commented Jan 31, 2024

There was opened a bugreport in the Debian BTS: https://bugs.debian.org/1061956

@RincewindsHat
Copy link
Member

@waja Backport #1901 maybe?

@waja
Copy link
Member

waja commented Jan 31, 2024

This was requested for approval: https://bugs.debian.org/1062063

@waja
Copy link
Member

waja commented Feb 5, 2024

Should be included into the next point release (this weekend).

@teutat3s
Copy link

When would be the next scheduled release? We are really looking forward for the integration of this fix.

@RincewindsHat
Copy link
Member

we don't have scheduled releases, but if @waja feels like it, we could do one :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants