fixed NumberFormatException #107 issue in upstream #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ms1111
reviewed
Aug 24, 2017
| @@ -280,7 +280,7 @@ String formattedContents() { | |||
| switch(currentCell.getType()) { | |||
| case "s": //string stored in shared table | |||
| if (!lastContents.isEmpty()) { | |||
| int idx = Integer.parseInt(lastContents); | |||
| int idx = Integer.parseInt(lastContents.trim()); | |||
There was a problem hiding this comment.
@bvn13 Cool, seems there are lots of issues around malformed SST references out in the wild. I saw some blank ones which is where the if (!lastContents.isEmpty()) came in iirc.
Probably makes sense to change the if-statement from if (!lastContents.isEmpty()) to if (!lastContents.isEmpty() && !lastContents.trim().isEmpty()), so if the value is just whitespace it won't throw a NumberFormatException.
Could you please add a unit test for the failing case? You could probably adapt blank_sst_reference_doctored.xlsx if you don't have a sample you can share. See StreamingReaderTest.testShouldHandleBlankSSTReference() for an example.
|
This PR still needs a unit test before it can be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.