POI 4.1 #189
Merged
POI 4.1 #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 9, 2019 15:04
monitorjbl
reviewed
May 7, 2019
| @@ -711,24 +711,24 @@ public void testFormulaWithDifferentTypes() throws Exception { | |||
| Row next = rowIterator.next(); | |||
| Cell cell = next.getCell(0); | |||
|
|
|||
| assertThat(cell.getCellTypeEnum(), is(CellType.STRING)); | |||
| assertThat(cell.getCellType(), is(CellType.STRING)); | |||
There was a problem hiding this comment.
Why did this method call change? I don't see any removal of the original method in StreamingCell. Is getCellType() method preferable for some reason?
There was a problem hiding this comment.
getCellTypeEnum is deprecated - getCellType is the replacement
| factory.setXIncludeAware(false); | ||
| return factory.newDocumentBuilder().parse(is); | ||
| } catch(SAXException | IOException | ParserConfigurationException e) { | ||
| return DocumentHelper.readDocument(is); |
There was a problem hiding this comment.
Neat! Now we don't have to maintain this, but at least there's still a unit test backstop in case the CVE crops up again for some reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new POI code makes it important to have getSheet() implemented on cells. That is the main reason why I refactored a number of classes.