JsonViewSupportFactoryBean replaces all other converters?

[aabeling]

Hi,

is it right that the JsonViewSupportFactoryBean replaces all other converters in
https://github.com/monitorjbl/json-view/blob/master/spring-json-view/src/main/java/com/monitorjbl/json/JsonViewSupportFactoryBean.java#L33 ?

Then in
https://github.com/monitorjbl/json-view/blob/master/spring-json-view/src/main/java/com/monitorjbl/json/JsonViewSupportFactoryBean.java#L40
the converter is added again?!

How about just replacing a possibly existing MappingJackson2HttpMessageConverter instead?
Now my application misses the Jaxb2RootElementHttpMessageConverter which it had before.

Thanks for this work so far.
Best regards
Achim

[tadas-subonis]

Ran into the same problem. I've removed line

adapter.setMessageConverters(Collections.<HttpMessageConverter<?>>singletonList(converter));

and it fixed my issues and it seems that it didn't break anything else.

[tadas-subonis]

Now the (our internal/custom) class looks:

package com.monitorjbl.json;

import com.fasterxml.jackson.databind.ObjectMapper;
import org.springframework.beans.factory.InitializingBean;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.http.converter.HttpMessageConverter;
import org.springframework.web.method.support.HandlerMethodReturnValueHandler;
import org.springframework.web.servlet.mvc.method.annotation.HttpEntityMethodProcessor;
import org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter;
import org.springframework.web.servlet.mvc.method.annotation.RequestResponseBodyMethodProcessor;

import java.util.ArrayList;
import java.util.Collections;
import java.util.List;

public class JunoJsonViewSupportFactoryBean implements InitializingBean {

    @Autowired
    private RequestMappingHandlerAdapter adapter;
    private final JsonViewMessageConverter converter;

    public JunoJsonViewSupportFactoryBean() {
        this(new ObjectMapper());
    }

    public JunoJsonViewSupportFactoryBean(ObjectMapper mapper) {
        this.converter = new JsonViewMessageConverter(mapper.copy());
    }

    @Override
    public void afterPropertiesSet() throws Exception {
        List<HandlerMethodReturnValueHandler> handlers = new ArrayList<>(adapter.getReturnValueHandlers());
        decorateHandlers(handlers);
        adapter.setReturnValueHandlers(handlers);
    }

    private void decorateHandlers(List<HandlerMethodReturnValueHandler> handlers) {
        List<HttpMessageConverter<?>> converters = new ArrayList<>(adapter.getMessageConverters());
        converters.add(converter);
        for (HandlerMethodReturnValueHandler handler : handlers) {
            int index = handlers.indexOf(handler);
            if (handler instanceof HttpEntityMethodProcessor) {
                handlers.set(index, new JsonViewHttpEntityMethodProcessor(converters));
            } else if (handler instanceof RequestResponseBodyMethodProcessor) {
                handlers.set(index, new JsonViewReturnValueHandler(converters));
                break;
            }
        }
    }

}

[draas1]

I too had the same problem (and fix).

To me, the offending line mentioned above seems like a mistake. If removing that line breaks functionality in some way, the please let me know.

[monitorjbl]

Pushed a fix to the latest snapshot version, would you mind giving that a try? If you don't have any issues, I'll release it to Maven Central.