Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automerged branches are not automerged when a build completes #2

Closed
monitorjbl opened this issue May 12, 2015 · 5 comments
Closed

Automerged branches are not automerged when a build completes #2

monitorjbl opened this issue May 12, 2015 · 5 comments
Labels
Milestone

Comments

@monitorjbl
Copy link
Owner

If a PR is approved and waiting on a build to complete before merging, the automerge functionality does not detect when the build completes successfully.

@monitorjbl
Copy link
Owner Author

For reference, as of Stash 3.6.1 there is no event to listen to for builds.

@monitorjbl monitorjbl added the bug label Jun 13, 2015
@monitorjbl
Copy link
Owner Author

It looks like it's possible to have an event listener for all build events: https://developer.atlassian.com/static/javadoc/stash/3.10.0/build-integration/reference/com/atlassian/stash/build/BuildStatusSetEvent.html

@monitorjbl monitorjbl modified the milestone: 1.4 Jun 13, 2015
monitorjbl added a commit that referenced this issue Jun 13, 2015
@davfifa
Copy link

davfifa commented Jun 17, 2015

Just wonder if there is no build associated with the repo, will a PR get auto-merged? Seems not working here.

@monitorjbl
Copy link
Owner Author

The plugin listens only to approval events in the latest release. This is fine for simple cases, but if you've configured your repo to block PRs until there's a successful build then the PR won't automerge. It's kind of a pain if you've got a full CI workflow.

There is a build complete event hook as of Stash 3.9.1. With that, the plugin can trigger an automerge if the PR is approved.

@monitorjbl monitorjbl modified the milestones: 1.4, 1.5 Jun 21, 2015
@monitorjbl
Copy link
Owner Author

I'm going to wait to fix this until version 1.5. It will break compatibility with Stash 3.6 and I want to get the other issues for 1.4 resolved without requiring a version upgrade of Stash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants