Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(back): add route to expose favicon from rice bundle #147

Merged
merged 2 commits into from
Feb 6, 2020

Conversation

jsdidierlaurent
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

Merging #147 into master will increase coverage by 0.52%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
+ Coverage    98.2%   98.72%   +0.52%     
==========================================
  Files          57       57              
  Lines        1723     1726       +3     
==========================================
+ Hits         1692     1704      +12     
+ Misses         31       22       -9
Flag Coverage Δ
#core 98.72% <100%> (+0.52%) ⬆️
Impacted Files Coverage Δ
service/server.go 95.52% <100%> (+14.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bd1328...a4cdf06. Read the comment docs.

@jsdidierlaurent jsdidierlaurent merged commit 7f95988 into master Feb 6, 2020
@jsdidierlaurent jsdidierlaurent deleted the fix-missing-favicon branch February 6, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant