Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Off-centered #54

Closed
veganexe opened this issue Oct 10, 2017 · 10 comments
Closed

Off-centered #54

veganexe opened this issue Oct 10, 2017 · 10 comments
Labels

Comments

@veganexe
Copy link

veganexe commented Oct 10, 2017

monitorr

The container is off-centered

@veganexe veganexe changed the title The header is off-centered Off-centered when resized Oct 10, 2017
@veganexe veganexe changed the title Off-centered when resized Off-centered header Oct 10, 2017
@veganexe veganexe changed the title Off-centered header Off-centered Oct 10, 2017
@veganexe
Copy link
Author

Why "wontfix"? Can you please give me a workaround at least? Monitorr is just perfect for my project even at this stage. Just need to fix the centering. Using 128x128 cards

@seanvree
Copy link
Member

@veganexe you've edited the css too much. There's no way to tell why it's not centered. But, if I had to guess, I would say it's something with the clock.

@wjbeckett
Copy link
Contributor

wjbeckett commented Oct 10, 2017

The reason it's a wontfix is because you've change so much we wouldn't know where to begin to troubleshoot.

Monitorr is built on Bootstrap so heavily modifying the index and CSS files can start to cause issues.

Can you add some more tiles (so there is at least 6) and see if you still have the issue?

@veganexe
Copy link
Author

Adding more tiles did not help, here are the diff logs

diffchecker.com/dsaG4xNz
diffchecker.com/FPWLdX0B

@jrdnlc
Copy link

jrdnlc commented Oct 10, 2017

Where did you get that theme? Did you create it yourself? @veganexe

@veganexe
Copy link
Author

Yes, I did.

And back to the topic, it seems it is off centered by default. Try keeping 4 tiles and a single word header and view in the Mobile mode of your browser to see that off-centered container

@wjbeckett
Copy link
Contributor

wjbeckett commented Oct 11, 2017

No issues here.
Again, this is because you have modified the CSS and index enough that it has broken the Bootstrap layout.

screenshot_20171011-105157

@veganexe
Copy link
Author

:3 it looked off for me. Anyway can you please take a look at the diff log and try to find the issue? I don't want that theming work to go useless cuz of a teeny off-center :(

@wjbeckett
Copy link
Contributor

My screenshot clearly shows that the DEFAULT unmodified theme is not off centre.
We will not troubleshoot your issue for you at this stage as theming is not on our roadmap just yet.
Because of how Bootstrap works with Monitorr, adjusting the index and CSS will absolutely cause issues if you don't stick to Bootstrap methods.

I would suggest that you roll back your changes to the tile sizes and any index modifications and make sure it works for you 'out of the box'.

Then, change the div from col-lg-4 to col-lg-1. That might get you in the right direction.

Again, we will not be fixing this issue for you as theming is not on our roadmap just yet. This issue will remain closed and tagged as wontfix.

@jonathanfinley
Copy link
Member

Just to add, It's not that we are no supporting theming or anything of the sort, by all means! While this project grows please by all means offer ideas, make changes, show us what we could incorporate, etc. As one of the main CSS contributors, I'd heavily consider what @wjbeckett recommend, starting from scratch to ensure that the project does indeed work as it is supposed to. After that, then start tweaking down. At this moment, We agree that we are not offering full support towards theming but in the future would definitively like to offer a way for all users to be able to tweak the CSS. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants