Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove macro paradise for 2.13 #14

Merged
merged 2 commits into from
May 30, 2018
Merged

remove macro paradise for 2.13 #14

merged 2 commits into from
May 30, 2018

Conversation

eed3si9n
Copy link
Contributor

build.sbt Outdated
else Nil
},
scalacOptions ++= {
if (under213 contains scalaBinaryVersion.value) Nil

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this handle Scala nightly releases that have binary version 2.12.6-bin-abcd123? Would val needsParadise = Def.settingKey(scalaVersion.startsWith("2.13")) work instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.12.6-bin-abcd123 should work since that would be considered 2.12. I'd be happy to add a setting key if that makes more sense.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops that was supposed to be 2.13.0-bin-abcd

lazy val requiredMacroCompatDeps = Seq(
needsScalaParadise := {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks better. It would be nice to expose cross-building utilities like these as an sbt plugin so the same boilerplate doesn't need to be copy-pasted all the time 🤔

build.sbt Outdated
else Nil
},
scalacOptions ++= {
if (under213 contains scalaBinaryVersion.value) Nil

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops that was supposed to be 2.13.0-bin-abcd

@alexandru alexandru merged commit c4b61eb into monix:master May 30, 2018
@eed3si9n eed3si9n deleted the wip/2.13 branch May 30, 2018 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants