New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove macro paradise for 2.13 #14

Merged
merged 2 commits into from May 30, 2018

Conversation

Projects
None yet
3 participants
@eed3si9n
Contributor

eed3si9n commented May 28, 2018

build.sbt Outdated
else Nil
},
scalacOptions ++= {
if (under213 contains scalaBinaryVersion.value) Nil

This comment has been minimized.

@olafurpg

olafurpg May 28, 2018

Does this handle Scala nightly releases that have binary version 2.12.6-bin-abcd123? Would val needsParadise = Def.settingKey(scalaVersion.startsWith("2.13")) work instead?

This comment has been minimized.

@eed3si9n

eed3si9n May 28, 2018

Contributor

2.12.6-bin-abcd123 should work since that would be considered 2.12. I'd be happy to add a setting key if that makes more sense.

This comment has been minimized.

@olafurpg

olafurpg May 29, 2018

Whoops that was supposed to be 2.13.0-bin-abcd

lazy val requiredMacroCompatDeps = Seq(
needsScalaParadise := {

This comment has been minimized.

@olafurpg

olafurpg May 29, 2018

This looks better. It would be nice to expose cross-building utilities like these as an sbt plugin so the same boilerplate doesn't need to be copy-pasted all the time 🤔

build.sbt Outdated
else Nil
},
scalacOptions ++= {
if (under213 contains scalaBinaryVersion.value) Nil

This comment has been minimized.

@olafurpg

olafurpg May 29, 2018

Whoops that was supposed to be 2.13.0-bin-abcd

@alexandru alexandru merged commit c4b61eb into monix:master May 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eed3si9n eed3si9n deleted the eed3si9n:wip/2.13 branch May 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment