Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #27: Replace TestUtils with portable-scala-reflect. #28

Merged
merged 1 commit into from
Sep 16, 2018

Conversation

sjrd
Copy link
Contributor

@sjrd sjrd commented Sep 16, 2018

TestUtils is deprecated in Scala.js 0.6.25, and removed in Scala.js 1.0.0-M5. Its use cases are replaced by the more general https://github.com/portable-scala/portable-scala-reflect library.

`TestUtils` is deprecated in Scala.js 0.6.25, and removed in
Scala.js 1.0.0-M5. Its use cases are replaced by the more general
https://github.com/portable-scala/portable-scala-reflect library.
@sjrd
Copy link
Contributor Author

sjrd commented Sep 16, 2018

The Travis build fails, but so does master, so I'm not going to try and fix it.

Locally, both minitestJVM/test and minitestJS/test pass, as well as lawsJVM/test and lawsJS/test.

@alexandru
Copy link
Member

Thanks a lot @sjrd, will take it from here.

@alexandru alexandru merged commit 27bed27 into monix:master Sep 16, 2018
@sjrd sjrd deleted the use-portable-scala-reflect branch September 16, 2018 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants