Fix nondeterministic behavior in Observable.zip operators #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasil
commented
May 31, 2020
| continueP = Promise[Ack]() | ||
| oldP.completeWith(lastAck) |
There was a problem hiding this comment.
This one is a bit puzzling... The method is called from "synchronized" block but I noticed that onNext was allowing the next element in between completing lastAck and replacing continueP with a new promise
Avasil
commented
May 31, 2020
| @@ -56,7 +56,9 @@ private[reactive] final class Zip3Observable[A1, A2, A3, +R]( | |||
| // MUST BE synchronized by `lock` | |||
| var continueP = Promise[Ack]() | |||
| // MUST BE synchronized by `lock` | |||
| var completeWithNext = false | |||
| var sourcesCompleted: Int = 0 | |||
There was a problem hiding this comment.
Might be faster with N booleans or Byte but I'll just leave an issue about it.
It might not matter so I'd rather not spend time on it right now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1167
Fixes #1164